fix: reload language server client on restart #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the client watcher and output channel are disposed during a restart before the new client is creates, and also show a helper warning when certain variables are changed that require a restart. Also catch errors starting the client, so that our restart configuration change handler is still registered in case the user fixes their serverPath or something like that. Similarly, always register the restart command in case user wants to start using language server after not using it before. Closes nix-community#419
ian-h-chamberlain
force-pushed
the
fix/reload-client-on-restart
branch
from
3327cb5
to
886de87
Compare
|
Thanks @ian-h-chamberlain ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the client watcher and output channel are disposed during a restart before the new client is creates, and also show a helper warning when certain variables are changed that require a restart.
Also catch errors starting the client, so that our restart configuration change handler is still registered in case the user fixes their serverPath or something like that. Similarly, always register the restart command in case user wants to start using language server after
not using it before.
Closes #419