Skip to content
This repository was archived by the owner on Mar 23, 2025. It is now read-only.

Allow other partition tables and filesystems #79

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

tstat
Copy link
Contributor

@tstat tstat commented Nov 3, 2024

No description provided.

@tstat tstat force-pushed the flexible-partition-table-and-fs branch from 99f95c7 to f872d77 Compare November 4, 2024 02:58
@tstat tstat force-pushed the flexible-partition-table-and-fs branch from b23894d to beb01f0 Compare November 11, 2024 16:50
@tstat tstat marked this pull request as ready for review November 11, 2024 16:56
Copy link
Contributor

@MinerSebas MinerSebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also fix setting boot.initrd.systemd.enable = true;?
I broke my installation when using it.
My uneducated guess is, that this is the culprit:
https://github.com/NixOS/nixpkgs/blob/0f1c50858f16ba4e9743abd607cba7c66e87510a/nixos/modules/system/boot/systemd/initrd.nix#L390-L391

Also the readme isn't updated yet with this change.

@tstat
Copy link
Contributor Author

tstat commented Nov 12, 2024

thanks for the review @MinerSebas!

@tstat tstat merged commit 3a016ff into master Nov 12, 2024
2 checks passed
@tstat tstat deleted the flexible-partition-table-and-fs branch November 12, 2024 23:23
@Nebucatnetzer
Copy link

Nebucatnetzer commented Nov 19, 2024

I'm a bit confused by this pull request.
I can see that we can customize the firmware partition but the root partition as far as I can tell is hardcoded to ext4 or is there a way to override the rootfsImage variable?
And what about the fsType further down?

https://github.com/nix-community/raspberry-pi-nix/pull/79/files#diff-4ecb3d0364b87606a85cf915fd2580e2367912b08f0b14c1dad6eca051a540e1R25

@tstat
Copy link
Contributor Author

tstat commented Nov 19, 2024

this change just makes it so you can go through the normal nixos-install flow to setup a pi however you like. For example, I have a pi 5 with a guid partition table and btrfs that I manually partitioned, so I don't import sd-image in that config.

@Nebucatnetzer
Copy link

How do you build an image that way?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants