feat: Sort override build systems more strictly #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves consistency and readability. Helps with nix-community#1320.
Easier to read, and can be piped directly into `patch -p0`.
…field Improves consistency. Most entries are already sorted this way. Improves readability, since entries are now sorted in increasing chronological order. Helps with nix-community#1320.
Makes the filter much easier to read, now that it's getting more complex.
Doesn't change build-systems.json, because this is already the case. Helps with nix-community#1320.
l0b0
force-pushed
the
feat/sort-override-build-systems-more-strictly
branch
from
6dfe669 to
5ac36da
Compare
After sorting by the `from` and `until` versions. Helps with nix-community#1320.
l0b0
force-pushed
the
feat/sort-override-build-systems-more-strictly
branch
from
5ac36da to
ae35a2e
Compare
String entries apply to _all_ versions, so it makes sense for them to be first in the build systems lists.
l0b0
force-pushed
the
feat/sort-override-build-systems-more-strictly
branch
from
bc06a64 to
d5ea9cd
Compare
cpcloud
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1320.
jqdoes not yet support sorting by locale, so there are some slightly awkward sorts like "hatch-vcs" before "hatchling".FYI @moonshxne @cpcloud