Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional build-systems entries #1319

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

purcell
Copy link
Member

@purcell purcell commented Sep 21, 2023

For:

  • shandy-sqlfmt
  • textual-dev
  • textual-textarea

(All of these are required to build https://github.com/tconbeer/harlequin, a TUI DuckDB IDE)

It seemed excessive to add all the test boilerplate for each individually, but I did it anyway since this has been requested in other recent PRs. Let me know if there was an easier route I should have followed.

The PR additionally changes the build-systems override for py-tree-sitter, which is not actually an installable python package. A nixpkgs entry with this name exists, but the pypi package is simply tree-sitter, and one of the above libraries depends on it.

@purcell purcell force-pushed the more-build-system-overrides branch from 1d049b7 to 55afd46 Compare September 21, 2023 15:23
@purcell purcell force-pushed the more-build-system-overrides branch 2 times, most recently from 21fea37 to 24b3b91 Compare September 21, 2023 15:50
@purcell
Copy link
Member Author

purcell commented Sep 21, 2023

I'm still a committer here but it's been a while, so I'll request a cursory review rather than merging.

@purcell purcell requested a review from cpcloud September 21, 2023 16:00
@cpcloud
Copy link
Collaborator

cpcloud commented Sep 22, 2023

Nice!

Are you using harlequin for something? 🙂 Ah, you mentioned it

@cpcloud
Copy link
Collaborator

cpcloud commented Sep 22, 2023

Does py-tree-sitter need to remain? I assume it was added for some reason.

@purcell
Copy link
Member Author

purcell commented Sep 22, 2023

Does py-tree-sitter need to remain? I assume it was added for some reason.

I'm happy to leave it there, and perhaps that's safer, but what I suspect happened is that someone took all the pythonPackages entries in nixpkgs and added them to the overrides here. However, not all of those python packages in nixpkgs are actual installable PyPi packages — py-tree-sitter, for example, was what was built from the py-tree-sitter repo, and possibly pre-dated PyPi publishing of that code, but even that repo lists the installable package name as tree_sitter.

@purcell purcell force-pushed the more-build-system-overrides branch from 24b3b91 to 499f61b Compare September 22, 2023 12:05
@purcell
Copy link
Member Author

purcell commented Sep 22, 2023

I've just reverted the removal of py-tree-sitter, to be on the safe side.

@purcell
Copy link
Member Author

purcell commented Sep 22, 2023

Also, hi again, nice to see you're doing fun data stuff in your new day job too.

@cpcloud cpcloud added this pull request to the merge queue Sep 22, 2023
@purcell
Copy link
Member Author

purcell commented Sep 22, 2023

I was wondering what the deal is with syncing these overrides across to nixpkgs these days? Looks like a couple of months since it was last done. Can I help? Having the overrides arrive there would be a prerequisite for my harlequin PR in nixpkgs.

Merged via the queue into nix-community:master with commit 3274fd9 Sep 22, 2023
115 checks passed
@purcell purcell deleted the more-build-system-overrides branch September 22, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants