plugins/base16: minor improvements

[player131007]

Fixes #986

[GaetanLepage]

Thank you for the contribution.
Most of the changes make sense.
However, what would be the point of having the colorscheme option set to null ?

[player131007]

We initialized customColorScheme in extraConfigLuaPre. If colorscheme was not null, it would come after customColorScheme in the config and reset the colorscheme

[GaetanLepage]

We initialized customColorScheme in extraConfigLuaPre. If colorscheme was not null, it would come after customColorScheme in the config and reset the colorscheme

I am not sure to get what you mean ?

Why do a user would want to leave colorscheme.base16.colorscheme = null ?
I would say that this is an "invalid" configuration, don't you think ?

[player131007]

I am not sure to get what you mean ?

If both colorscheme and customColorScheme is not null, init.lua will look something like this:

-- extraConfigLuaPre goes here
require('base16-colorscheme').setup(customColorScheme)


-- extraConfigVim goes here (which includes colorscheme)
vim.cmd [[
  colorscheme base16-colorscheme
]]

Why do a user would want to leave colorscheme.base16.colorscheme = null ?

If they want to set a custom theme, they can leave colorscheme = null and set customColorScheme instead.

[traxys]

It's a bit of a footgun as is, as two options interact in strange ways.

I'd suggest adding a warning if customColorScheme != null and colorscheme != null, and an error if colorscheme == null and customColorScheme == null (see other plugins for inspiration)

[traxys]

I think you need to update some tests