Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/rustaceanvim: Allow to add on_attach to rustaceanvim #979

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

traxys
Copy link
Member

@traxys traxys commented Jan 25, 2024

This is useful to display inlay hints in neovim >=0.10 for example

@traxys traxys requested a review from GaetanLepage January 25, 2024 16:30
Comment on lines 287 to 289
plugins.lsp.postConfig = ''
vim.g.rustaceanvim = ${helpers.toLuaObject globalOptions}
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plugins.lsp.postConfig = ''
vim.g.rustaceanvim = ${helpers.toLuaObject globalOptions}
'';
plugins.lsp.postConfig = let
globalOptions = with cfg; {
...
};
in ''
vim.g.rustaceanvim = ${helpers.toLuaObject globalOptions}
'';

I would rather preserve the "scope locality".

@traxys traxys force-pushed the rustaceanvim_attach branch from 3797bbe to 9e7c51b Compare January 26, 2024 13:34
@traxys traxys requested a review from GaetanLepage January 26, 2024 13:35
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@traxys traxys merged commit 368f4d6 into nix-community:main Jan 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants