Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrappers: Extend and document the makeNixvim function #86

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

traxys
Copy link
Member

@traxys traxys commented Dec 21, 2022

The build function has be changed to the makeNixvim function. This also adds a full example of flake that allows to include nixvim.

README.md Outdated Show resolved Hide resolved
@traxys
Copy link
Member Author

traxys commented Dec 28, 2022

I'll come back later to this PR, I first want to see if I can't revamp a bit the makeNixvim function.

This allows to pass overlays and other such modifications of nixpkgs.
@traxys traxys changed the title README: Update the documentation on the standalone usage Wrappers: Extend and document the makeNixvim function Dec 28, 2022
@traxys
Copy link
Member Author

traxys commented Dec 28, 2022

As the changes to makeNixvim were quite small I added them to this PR, updating the title in consequence

flake.nix Outdated Show resolved Hide resolved
This is useful to be able to take full advantage of the Nix module
system, with `imports` and `options`.
The following information were out of date or incomplete:

- The `build` function has be changed to the `makeNixvim` function.
- `makeNixvimWithModule` has been introduced in order to allow more
customization.
- Added a full example using nixvim in a standalone flake
Copy link
Collaborator

@pta2002 pta2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@pta2002 pta2002 merged commit 660c931 into nix-community:main Dec 29, 2022
@traxys traxys deleted the readme_standalone branch December 29, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants