-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/null-ls: migrate null-ls
to none-ls
#641
Conversation
Good idea !
imports = [
(
mkRenamedOptionModule
["plugins" "null-ls"]
["plugins" "none-ls"]
)
]; |
none-ls-nvim
as default packagenull-ls
to none-ls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thank you for doing that :)
@siph This PR was marked as a draft. Do you agree to merge it now ? |
I think this is ready. I left the config documentation as-is because |
Shouldn't this be nixvim/plugins/none-ls/helpers.nix Line 65 in 77a3f3c
There are also still some occurences of |
It think not according to
From the PR request. Maybe they changed that stance, but that's another problem. |
It's kind of weird. That's why this PR originally only changed the default package and nothing else. When you asked me to rename to |
Ok, makes sense. Thank you for those explanations ! |
null-ls
was archived some time ago andnone-ls
is a fork and a drop-in replacement.none-ls
is packaged but not merged onto unstable yet (https://nixpk.gs/pr-tracker.html?pr=258774), so I am marking this as a draft.This pr just replaces the default package with
none-ls
. I don't think this requires any deprecations or warnings because it doesn't make any breaking changes, plus the package is still configurable. From thenone-ls
readme:FWIW,
LazyVim
has also migrated tonone-ls
: LazyVim/LazyVim#1517