ci/update: cleanup & fix re-apply logic now that we use nixvim-ci[bot]
#3418
Conversation
Get id, name, & email in a single `user-info` step.
We need to look for a commit authored by `nixvim-ci[bot]`, not `github-actions[bot]`.
MattSturgeon
force-pushed
the
ci/fix-update-reapply
branch
from
6c0691b to
80934be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
|
Git push to origin failed for nixos-25.05 with exitcode 1 |
|
Git push to origin failed for nixos-24.11 with exitcode 1 |
|
Git push to origin failed for nixos-25.05 with exitcode 1 |
|
Git push to origin failed for nixos-24.11 with exitcode 1 |
The actual error is:
I.e. we can't backport workflow changes because I'm unsure if we want to change this, and if so whether it needs explicit permissions in the We probably also need to ask an org owner to add the permission to our app installation? Unless @GaetanLepage is able? This would be a two step process; first edit the nixvim-ci app itself to "require" the permission, then re-authenticate the repo installation to "accept" the new permissions. |
Hm. I'm not sure why #3423 was successful when this wasn't... Maybe because this adds a "step" with a different id ( |
#3412 demonstrated that the "re-apply extra commits" logic is broken now that we commit updates as
nixvim-ci[bot]. The logic is still looking for a base commit authored bygithub-actions[bot].Additionally, include some cleanup refactoring for how we get the committer info. This is the same logic used in my personal config and also recently added to home-manager's CI.