Skip to content

plugins/yaml-schema-detect: init #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

plugins/yaml-schema-detect: init #3414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions plugins/by-name/yaml-schema-detect/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
lib,
config,
options,
...
}:
lib.nixvim.plugins.mkNeovimPlugin {
name = "yaml-schema-detect";
packPathName = "yaml-schema-detect.nvim";
package = "yaml-schema-detect-nvim";

description = ''
A Neovim plugin that automatically detects and applies YAML schemas for your YAML files using yaml-language-server (yamlls)
'';

extraConfig = cfg: {
warnings = lib.nixvim.mkWarnings "plugins.yaml-schema-detect" [
{
when = !config.plugins.which-key.enable;
message = ''
This plugin requires `plugins.which-key` to be enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this requirement mentioned on the plugin's README.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they do not appear to be there, but when I tried running the tests without it it would complain that it needs which-key

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be an upstream bug; maybe they have which-key integration that forgets to check it is present before importing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in their init.lua

${options.plugins.which-key.enable} = true;
'';
}
];
};

maintainers = [ lib.maintainers.FKouhai ];
}
8 changes: 8 additions & 0 deletions tests/test-sources/plugins/by-name/yaml-schema-detect/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
# empty test case is not needed since having it would make the warning throw an error
# this plugin requires which-key
combine-plugins = {
plugins.which-key.enable = true;
plugins.yaml-schema-detect.enable = true;
};
}