ci: check repo before running publish jobs #3407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MattSturgeon
commented
May 29, 2025
MattSturgeon
commented
- ci: check repo before running publish jobs
- ci/flakehub-publish-rolling: use context for repo name
- ci/flakestry-publish-rolling: add workflow name
MattSturgeon
commented
Jun 3, 2025
| @@ -5,6 +5,7 @@ on: | |||
| - "main" | |||
| jobs: | |||
| flakehub-publish: | |||
| if: github.repository == 'nix-community/nixvim' | |||
There was a problem hiding this comment.
It would be better practice to check necessary variables are present instead of checking the repo or owner. That approach would allow deliberate testing of forks while still preventing accidental runs.
This PR is still good to merge if we don't have the energy to find a better solution right now.
khaneliman
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.