docs/mdbook: install directly to $out (backport #3366)
#3370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
GaetanLepage
approved these changes
May 23, 2025
(cherry picked from commit e3f4a57)
MattSturgeon
force-pushed
the
mergify/bp/nixos-25.05/pr-3366
branch
from
d0a6d72 to
3117e87
Compare
| (cd "$doc_derivation"/share/doc && ${pkgs.lib.getExe pkgs.python3} ${./server.py}) | ||
| (cd "$doc_derivation" && ${pkgs.lib.getExe pkgs.python3} ${./server.py}) |
There was a problem hiding this comment.
To avoid needing to backport #3349, I've updated this line instead.
MattSturgeon
approved these changes
May 23, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by #3349; that PR serves the docs from the root of the docs derivation, however docs are actually installed to
$out/share/doc.IMO there's no reason to put a MDBook website in
share/doc/, so rather than fixingserve-docs'--chdirI've instead changed the docs to install to the root of$out.This is an automatic backport of pull request #3366 done by [Mergify](https://mergify.com).