-
-
Notifications
You must be signed in to change notification settings - Fork 334
update-scripts: add "version-info" and run it in update CI #3351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MattSturgeon
commented
May 22, 2025
- update-scripts: get nixpkgs using flak-compat
- update-scripts/version-info: init
- update-scripts: move update logic from CI to dedicated script
- update-scripts/update: write version-info during update
- version-info: init
This ensures we get an actual nixpkgs flake, which will have source info like `rev`. It also means we have access to `nixvim` if we need it.
Writes a version-info.toml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Is this to later use nixvimOlder
& co?
I've ran into wanting version info a few times. Sometimes it'd be acceptable to use I didn't want this PR to grow into also implementing various use-cases for version info. Some uses include minor improvements to the docs, throwing assertions when the wrong nixpkgs channel is used, improving nixvim's "branching off a release" process, etc. There's probably other version info worth tracking in the |
66aba94
to
46fd0b1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Successfully created backport PR for |