Skip to content

dev/tests: add --attr option to print full attrpath of tests #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

MattSturgeon
Copy link
Member

Allows using the tests devshell command to discover the full attrpath of a test.

e.g.

$ tests --attr modules-lsp plugins-by-name-lazygit
Printing 2 tests: modules-lsp plugins-by-name-lazygit

Full attr paths:
- checks.x86_64-linux.test-2.entries.modules-lsp
- checks.x86_64-linux.test-18.entries.plugins-by-name-lazygit

@MattSturgeon MattSturgeon requested a review from a team May 17, 2025 02:59
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Allows using the `tests` devshell command to discover the full attrpath
of a test.

e.g.

```
$ tests --attr modules-lsp plugins-by-name-lazygit
Printing 2 tests: modules-lsp plugins-by-name-lazygit

Full attr paths:
- checks.x86_64-linux.test-2.entries.modules-lsp
- checks.x86_64-linux.test-18.entries.plugins-by-name-lazygit
```
@MattSturgeon MattSturgeon force-pushed the dev/tests/print-attrs branch from 31c9d0d to 14c7f5f Compare May 19, 2025 19:40
@MattSturgeon

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

mergify bot commented May 19, 2025

This pull request, with head sha 14c7f5f8968940d1730b5e935dd1d9f3e461a2d3, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 14c7f5f8968940d1730b5e935dd1d9f3e461a2d3 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch dev/tests/print-attrs, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 14c7f5f into nix-community:main May 19, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages May 19, 2025 19:47 Inactive
@MattSturgeon MattSturgeon deleted the dev/tests/print-attrs branch May 19, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants