Skip to content

plugins/timerly: init #3322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

plugins/timerly: init #3322

merged 1 commit into from
May 13, 2025

Conversation

FKouhai
Copy link
Contributor

@FKouhai FKouhai commented May 13, 2025

No description provided.

@FKouhai

This comment was marked as resolved.

@FKouhai

This comment was marked as resolved.

@FKouhai
Copy link
Contributor Author

FKouhai commented May 13, 2025

I tried the plugin locally with an updated flake
image

Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on a good start. Few comments.

@FKouhai FKouhai force-pushed the feat/add_timerly branch from aa85ab4 to 7d3d7bf Compare May 13, 2025 20:48
@MattSturgeon

This comment was marked as resolved.

@FKouhai FKouhai force-pushed the feat/add_timerly branch from 7d3d7bf to 0164ea6 Compare May 13, 2025 21:22
@MattSturgeon
Copy link
Member

I'm glad to see only the tests related to this plugin and the docs are failing though, meaning we've managed to achieve the lazy evaluation of packages described in #2004 🎉

i.e. if your nixvim doesn't use a particular plugin/package, the nixvim eval doesn't depend on it existing in your nixpkgs revision.

@FKouhai

This comment was marked as resolved.

@FKouhai FKouhai force-pushed the feat/add_timerly branch from 0164ea6 to ad4eb1e Compare May 13, 2025 21:26
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues from me, but is blocked by us bumping to a newer nixpkgs revision. See #3318

@MattSturgeon
Copy link
Member

should I nix flake update? the package is already in nixpkgs unstable

No, we'll handle the bump in #3318. You'll just have to rebase once that's merged.

Merged, should be good to rebase now

@FKouhai
Copy link
Contributor Author

FKouhai commented May 13, 2025

should I nix flake update? the package is already in nixpkgs unstable

No, we'll handle the bump in #3318. You'll just have to rebase once that's merged.

Merged, should be good to rebase now

omw boss

@FKouhai FKouhai force-pushed the feat/add_timerly branch from ad4eb1e to 1c53ad9 Compare May 13, 2025 21:50
@MattSturgeon

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor

mergify bot commented May 13, 2025

This pull request, with head sha 1c53ad9b2f5fd4a3c1f644d03895cda7756c92a3, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha 1c53ad9b2f5fd4a3c1f644d03895cda7756c92a3 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch feat/add_timerly, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit 1c53ad9 into nix-community:main May 13, 2025
4 checks passed
@mergify mergify bot temporarily deployed to github-pages May 13, 2025 22:01 Inactive
@MattSturgeon
Copy link
Member

Thanks!

@FKouhai FKouhai deleted the feat/add_timerly branch May 13, 2025 23:25
@GaetanLepage
Copy link
Member

Well done @FKouhai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants