-
-
Notifications
You must be signed in to change notification settings - Fork 333
plugins/timerly: init #3322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/timerly: init #3322
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are on a good start. Few comments.
This comment was marked as resolved.
This comment was marked as resolved.
I'm glad to see only the tests related to this plugin and the docs are failing though, meaning we've managed to achieve the lazy evaluation of packages described in #2004 🎉 i.e. if your nixvim doesn't use a particular plugin/package, the nixvim eval doesn't depend on it existing in your nixpkgs revision. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues from me, but is blocked by us bumping to a newer nixpkgs revision. See #3318
Merged, should be good to rebase now |
omw boss |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Thanks! |
Well done @FKouhai! |
No description provided.