Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: experimental re-write #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: experimental re-write #2884
Changes from all commits
b9aec4f
6c42d5a
96d8873
5d4f54d
00d0676
83350c7
599441a
d6eafb1
f09ff46
ba77348
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment would be nice to say what is discarded, I guess the why is that docs are "inert"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from the nixos docs impl, and there was no comment to copy. I'll try come up with something.
However, yeah "string context" is how nix keeps track of a string's dependencies. E.g. if you do
"${pkgs.hello}/bin/hello"
then that string has some "context" so that nix knows it has a dependency on thepkgs.hello
derivation.Using
unsafeDiscardStringContext
drops that context, sounsafeDiscardStringContext "${pkgs.hello}/bin/hello"
would have the same string value, but without the dependency on building thepkgs.hello
derivation.In the context of the docs, I believe this is mainly relevant for the "declared by" links, and maybe any
default
orexample
values that accidentally used a derivation in its value. I.e. we want the string value, but we don't want the dependency.