[BUG] Obsidian workspace path breaks flake check?

[repparw]

Field	Description
Plugin	obsidian
Nixpkgs	unstable
Home Manager	unstable

Trying to add ci/cd to my nixvim config i noticed it fails flake check, though it installs ok and nix run . also works.

Minimal, Reproducible Example (MRE)

    obsidian = {
      enable = true;
      settings = {
        workspaces = [
          {
            name = "obsidian";
            path = "~/Documents/obsidian";
          }
};

nix flake check gives an error about directory not found (build/Documents/obsidian, I believe)

I think it should ignore the path/s passed to obsidian, no?

[MattSturgeon]

The test builds nixvim and then runs neovim using your config.

It runs nvim in a nix build sandbox, so some things may not work.

In this case, it sounds like obsidian is looking for the path and printing an error, which our test catches.

The path won't exist in the nix build env, because $HOME is changed to ensure purity.

[repparw]

yeah, gotcha, still; this shouldn't break the rest of the check, probably?

I dunno, maybe it should be fixed upstream in obsidian.nvim to not require a workspace to be configured first, or fail more graciously?

I just tried nix run . with a path = "" and the plugin throws an error, probably the same one, otherwise everything works.

Example configs use path with ~/ as I did, and even absolute paths get to the same error, so... maybe a way to bypass it?

[repparw]

I guess other way would be to remove the obsidian config from the standalone nixvim config and add it as an override on my nixos config, that way it would be more pure? and flake check should work on it's own without any other modification?

This would imply taking the whole config from that plugin tho because you can't set it up without a workspace, it would also fail

[MattSturgeon]

Currently nixvim offers lib.nixvim.enableExceptInTests (see https://nix-community.github.io/nixvim/user-guide/helpers.html)

This won't work with the currently incubating "new" way to configure standalone nixvim, we're still figuring out how we want to be able to check "isTest" or whatever with that new approach.

But if you're using one of the documented approaches then enableExceptInTests may work.

[repparw]

ha, just commited this workaround

didn't check lib, my bad. I'll use that