nixos-anywhere: reimport facts after kexec and throw if kexec failed #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enzime
force-pushed
the
push-mrpmsymxtmkz
branch
from
18994f5 to
03058e6
Compare
Mic92
reviewed
Aug 11, 2025
src/nixos-anywhere.sh
Outdated
| @@ -541,9 +542,11 @@ importFacts() { | |||
| maybeSudo=sudo | |||
| elif [[ ${hasDoas} == "y" ]]; then | |||
| maybeSudo=doas | |||
| elif [[ ${hasRun0} == "y" ]]; then | |||
| maybeSudo=run0 | |||
There was a problem hiding this comment.
I also added run0 in https://github.com/nix-community/nixos-anywhere/pull/448/files but in my memory there was more required.
There was a problem hiding this comment.
I tested ssh host run0 whoami and it requires a TTY for authentication and outputs the prompt to stdout which I'm not sure will mess up nixos-anywhere so I've decided to drop it for now in this PR
Mic92
approved these changes
Aug 11, 2025
a-kenji
approved these changes
Aug 11, 2025
Enzime
force-pushed
the
push-mrpmsymxtmkz
branch
from
03058e6 to
8441ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can be more easily reviewed by going through each commit one at a time