-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to disable/enable phases in nixos-anywhere #369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
nixos-anywhere-phases
branch
4 times, most recently
from
September 9, 2024 15:20
f2c4c0d
to
f95e63a
Compare
Instead of having flags like --no-reboot or --stop-after-disko, we now can specify all phases to run.
this is dirty but for unknown reason the previous version would make the machine fail booting.
Mic92
force-pushed
the
nixos-anywhere-phases
branch
from
September 9, 2024 15:23
f95e63a
to
6a7cc81
Compare
Mic92
force-pushed
the
nixos-anywhere-phases
branch
from
September 9, 2024 15:43
e66da20
to
25a0874
Compare
phaer
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, haven't tested this (yet) :)
Mic92
force-pushed
the
nixos-anywhere-phases
branch
from
September 9, 2024 16:26
d356494
to
286e6ad
Compare
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ef708ac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having flags like --no-reboot or --stop-after-disko, we now can specify all phases to run.