Detect IPv6 automatically, Rewrite kexec url #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkg20001
force-pushed
the
automatic-ipv6-detection
branch
4 times, most recently
from
672c8ce
to
560e73c
Compare
Mic92
reviewed
Apr 29, 2024
Mic92
reviewed
Apr 29, 2024
|
cc @zimbatm because he is paying for the proxy. |
|
This pull request also needs to be rebased once #297 is merged. |
mkg20001
force-pushed
the
automatic-ipv6-detection
branch
2 times, most recently
from
c98a11c
to
dbb3366
Compare
This uses ip r g 1.1.1.1 to test if there's any route to an IPv4 internet host If that fails and the url is a github.com one it will change github.com to gh-v6.com, as specified in the documentation This saves the user from an extra manual step and makes nixos-anywhere better Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
mkg20001
force-pushed
the
automatic-ipv6-detection
branch
from
dbb3366
to
15216fc
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 313ac87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses ip r g 1.1.1.1 to test if there's any route to an IPv4 internet host
If that fails and the url is a github.com one it will change github.com to gh-v6.com,
as specified in the documentation
This saves the user from an extra manual step and makes nixos-anywhere better
The fallback behaviour if the ip binary cannot be found is to just assume ipv4 connectivity. I can invert that if wanted.