Don't preserve local permissions for --extra-files #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think some of flags where needed though. Now it is failing with: |
|
Well that's a bit embarrassing tbh, I forgot that |
|
Needed a rebase after the SSH connection changes on main, but conflicts are gone and tests are passing. |
phaer
added a commit
to phaer/nixos-remote
that referenced
this pull request
Jan 15, 2023
After removing -a in nix-community#15, remote extra files are implictly chowned according to the remote umask. So we (re-)add --perms to apply local file permissions remotely as this should mostly be expected behavior.
phaer
added a commit
to phaer/nixos-remote
that referenced
this pull request
Jan 15, 2023
After removing -a in nix-community#15, remote extra files are implictly chowned according to the remote umask. So we (re-)add --perms to apply local file permissions remotely as this should mostly be expected behavior. The second -F disables uploading the .rsync-filter file itself if it exists.
phaer
added a commit
to phaer/nixos-remote
that referenced
this pull request
Jan 15, 2023
After removing -a in nix-community#15, remote extra files are implictly chowned according to the remote umask. So we (re-)add --perms to apply local file permissions remotely as this should mostly be expected behavior. The second -F disables uploading the .rsync-filter file itself if it exists.
phaer
added a commit
to phaer/nixos-remote
that referenced
this pull request
Jan 15, 2023
After removing -a in nix-community#15, remote extra files are implictly chowned according to the remote umask. So we (re-)add --perms to apply local file permissions remotely as this should mostly be expected behavior. The second -F disables uploading the .rsync-filter file itself if it exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our rsync invocation so that the remote copies of --extra-files always belong to
root:root. I believe that's a safer default than copying local permissions in all cases. Without this change, files which should belong to root would need to locally belong to root as well. In cases where one would like other permissions on the remote system, one could chown them after copying.