libnixf: fix out-of-bounds access in Lexer::consumeManyOf
#443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While bumping my system flake I ran into a test failing due to an out-of-bounds access. It got caught by
_GLIBCXX_ASSERTIONS
. I guess the not-so-recent bump of meson in nixpkgs brought in this commit from meson 1.4.0.Here's the failing test logs and a backtrace:
lldb backtrace:
Maybe it's a good idea to bump nixpkgs for the new default meson behavior
or enable stdlib assertions with bounds-checking explicitly?