Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpptools needs an override #69

Open
fzakaria opened this issue Jul 17, 2024 · 7 comments
Open

cpptools needs an override #69

fzakaria opened this issue Jul 17, 2024 · 7 comments

Comments

@fzakaria
Copy link

cpptools downloads a binary and it's not executable or able to run.

❯ readlink -f /home/fmzakari/.vscode/extensions/ms-vscode.cpptools/debugAdapters/bin/OpenDebugAD7

/nix/store/cx9451yl9icy2zyh9shggq5vq8j0gy1c-vscode-extension-ms-vscode-cpptools-1.21.1/share/vscode/extensions/ms-vscode.cpptools/debugAdapters/bin/OpenDebugAD7

Nixpkgs has special handling for it (https://github.com/NixOS/nixpkgs/blob/nixos-24.05/pkgs/applications/editors/vscode/extensions/ms-vscode.cpptools/default.nix)

@deemp
Copy link
Collaborator

deemp commented Aug 23, 2024

@fzakaria, there's quite a lot of code, and I don't want to duplicate it. I suggest to use the version from nixpkgs. Alternatively, make a fork of nixpkgs, update the extension there, and use that version.

@fzakaria
Copy link
Author

okay

@deemp deemp closed this as completed Aug 23, 2024
@fzakaria
Copy link
Author

fzakaria commented Aug 23, 2024 via email

@deemp
Copy link
Collaborator

deemp commented Aug 24, 2024

@fzakaria, nice idea! I'll provide a mechanism for removing particular extensions and will remove this extension.

@Naxdy
Copy link

Naxdy commented Aug 30, 2024

Good call on removing the extension. However, it would be nice if upon trying to install it, nix would throw an error message during eval indicating what's wrong. error: attribute 'cpptools' missing isn't super descriptive as it stands.

@0x50F1A
Copy link

0x50F1A commented Sep 2, 2024

Good call on removing the extension. However, it would be nice if upon trying to install it, nix would throw an error message during eval indicating what's wrong. error: attribute 'cpptools' missing isn't super descriptive as it stands.

+1 just ran into this and wouldn't have figured it out without searching cpptools in this repo

@stereomato
Copy link

+2, just got hit with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants