-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos: use user service for activation #2548
base: master
Are you sure you want to change the base?
Conversation
25ab14f
to
d1c291b
Compare
I also suspect that this will fix https://gitlab.com/rycee/sd-switch/-/issues/2 |
44313f9
to
c92001a
Compare
f378091
to
20a1898
Compare
Hi, I've rebased this PR against master following #2971: ncfavier@d28c365. Feel free to force-pull from my fork:
(I haven't reviewed the changes, only fixed the conflicts.) |
20a1898
to
3c33445
Compare
@rycee why the test is failing with
? |
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
87a4452
to
0c4b136
Compare
0c4b136
to
540cc05
Compare
This compiles and works without any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be hidden behind an option home-manager.useUserService
or somesuch and default to false
at first. That way we could merge sooner without worrying about breaking people's configurations.
540cc05
to
84acd7a
Compare
@rycee bump? |
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
3a3e1d6
to
0eaa4fc
Compare
This is the best patch. With the introduction of this feature, errors no longer occur on systems that mount the home folder at login. |
0eaa4fc
to
1fc4297
Compare
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
@rycee bump? |
Yeah, sorry about the long delay here. I'm very much in favor of doing this, and ultimately I would like for activation through systemd to be the normal procedure, even for standalone installations. I've been slowly working towards this, for example, by experimenting in #4976. That said, perhaps it's worth getting this in before that work is done. |
Eventually, this can lead to upstreaming home manager (via a optional module) in nixpkgs right? |
My environment-specific issues were resolved with this patch. |
ditto |
I have already cherry-picked and used this best patch. |
systemd: remove unneeded XDG_RUNTIME_DIR workaround nixos: documentation about home manager status nixos: use enable for ssh_config units
1fc4297
to
9bbbe63
Compare
78c2aa8
to
3558f96
Compare
Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting. If you are the original author of the PR
If you are not the original author of the PR
|
bump This PR is really important. And it's just an option to make it user service, not forcing it to be one. |
Description
Use user units to activate home configurations. This has several benefits:
ssh is special cased so that its config file still is linked on boot to allow remote login.
If other components needs to be similarly special cased I could rework this PR to include a few dedicated options.
EDIT(@ncfavier): fixes #3415
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS
.