zip Launcher binary install, failure during registration

[rwaweber]

Bug description

Downloaded the launcher as NixOS-WSL-Launcher.zip from the 24.05.4 release, unzipped, and ran .\NixOS.exe install and was met with a stack trace.

Possibly of note, I previously had a NixOS-WSL installation(for a long while!), but I let the disk fill up and so had to delete it as it became unbootable. Totally my fault. 😅 I think the lack of visual reminders at a grub prompt, cause me to forget about cleaning up previous generations.

I figure it could be related, in the event that the delete and wsl --unregister NixOS that I ran may have left other artifacts around? I'm not super sure where I'd check for that, but if the stack trace smells like it could be related to that - feel free to close at your own discretion since its likely my fault. 😄

To Reproduce

Steps to reproduce the behavior:

• Download NixOS-WSL-Launcher.zip
• unzip
• Run from powershell .\NixOS.exe install

Logs

===== BEGIN STACK TRACE =====
Launcher.ContextualizedException: when registering the distribution
 ---> System.Runtime.InteropServices.COMException (0x8000000D): An illegal state change was requested. (0x8000000D)
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode)
   at Launcher.WSL.WslApiLoader.CheckResult(HRESULT hresult) in /_/Launcher/Launcher/src/WSL/Exception.cs:line 12
   at Launcher.WSL.WslApiLoader.WslRegisterDistribution(String distributionName, String tarGzFilename) in /_/Launcher/Launcher/src/WSL/WslRegisterDistribution.cs:line 19
   at Launcher.Helpers.InstallationHelper.<>c__DisplayClass0_0.<Install>b__0() in /_/Launcher/Launcher/src/Helpers/InstallationHelper.cs:line 29
   at Launcher.ExceptionContext.AddIfThrown(Action action, String context) in /_/Launcher/Launcher/src/ExceptionContext.cs:line 11
   --- End of inner exception stack trace ---
   at Launcher.ExceptionContext.AddIfThrown(Action action, String context) in /_/Launcher/Launcher/src/ExceptionContext.cs:line 13
   at Launcher.Helpers.InstallationHelper.Install() in /_/Launcher/Launcher/src/Helpers/InstallationHelper.cs:line 28
   at Launcher.Commands.Install.<>c.<GetCommand>b__0_0(Boolean reinstall) in /_/Launcher/Launcher/src/Commands/Install.cs:line 27
   at System.CommandLine.Handler.<>c__DisplayClass2_0`1.<SetHandler>b__0(InvocationContext context)
   at System.CommandLine.Invocation.AnonymousCommandHandler.Invoke(InvocationContext context)
   at System.CommandLine.Invocation.AnonymousCommandHandler.InvokeAsync(InvocationContext context)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Launcher.Program.<>c__DisplayClass1_0.<<Main>b__3>d.MoveNext() in /_/Launcher/Launcher/src/Program.cs:line 103
--- End of stack trace from previous location ---
   at Launcher.Program.<>c__DisplayClass1_0.<<Main>b__2>d.MoveNext() in /_/Launcher/Launcher/src/Program.cs:line 89
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass19_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__18_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__5_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass8_0.<<UseExceptionHandler>b__0>d.MoveNext()
====== END STACK TRACE ======

WSL version

WSL version: 2.3.26.0
Kernel version: 5.15.167.4-1
WSLg version: 1.0.65
MSRDC version: 1.2.5620
Direct3D version: 1.611.1-81528511
DXCore version: 10.0.26100.1-240331-1435.ge-release
Windows version: 10.0.26100.2894

[nzbr]

Microsoft recently introduced .wsl files as a successor to the distro launchers. The nixos.wsl file attached to the latest release is now the preferred installation method

Sorry you had to wait for my reply this long, because it is no lo her necessary, I will not investigate bugs in the launcher for the time being