chore(cloudflare-module): default to miniflare when using cloudflare presets - #4337
chore(cloudflare-module): default to miniflare when using cloudflare presets#4337KTrain5169 wants to merge 2 commits into
Conversation
|
@KTrain5169 is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| const runnerName = (ctx.nitro!.options.devServer.runner || | ||
| process.env.NITRO_DEV_RUNNER || | ||
| "node-worker") as RunnerName; | ||
| "miniflare") as RunnerName; |
There was a problem hiding this comment.
This is a wrong place. We should update cloudflare-dev preset
|
Thanks for PR ❤️ I have started a draft to update dev preset #4338 |
🔗 Linked issue
#4336
❓ Type of change
📚 Description
Resolves #4336
Nitro already depends on Miniflare directly. Given this, and that most people would want to run in as close of a simulation to production as possible, defaulting to the Miniflare runner is a good idea, which I've done here (hopefully).
📝 Checklist