Skip to content

chore(cloudflare-module): default to miniflare when using cloudflare presets - #4337

Closed
KTrain5169 wants to merge 2 commits into
nitrojs:mainfrom
KTrain5169:default-to-miniflare
Closed

chore(cloudflare-module): default to miniflare when using cloudflare presets#4337
KTrain5169 wants to merge 2 commits into
nitrojs:mainfrom
KTrain5169:default-to-miniflare

Conversation

@KTrain5169

Copy link
Copy Markdown

🔗 Linked issue

#4336

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #4336

Nitro already depends on Miniflare directly. Given this, and that most people would want to run in as close of a simulation to production as possible, defaulting to the Miniflare runner is a good idea, which I've done here (hopefully).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

@KTrain5169 is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 08604d8f-7a45-46c7-9d87-86b17c53f39d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread src/build/vite/env.ts
const runnerName = (ctx.nitro!.options.devServer.runner ||
process.env.NITRO_DEV_RUNNER ||
"node-worker") as RunnerName;
"miniflare") as RunnerName;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wrong place. We should update cloudflare-dev preset

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@pi0

pi0 commented Jun 11, 2026

Copy link
Copy Markdown
Member

Thanks for PR ❤️ I have started a draft to update dev preset #4338

@pi0 pi0 closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default to miniflare during local development with cloudflare-module preset

2 participants