Open
Conversation
|
@sandros94 is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Typecheck should be failing because of d3b1f7b |
📝 WalkthroughWalkthroughAdds a Bunny edge-scripting Nitro preset: updates preset aggregation and types, adds a Bunny preset module and runtime script, and includes tests and test helper updates to validate build artifacts and runtime behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@src/presets/bunny/runtime/edge-scripting.ts`:
- Around line 11-16: The preset for the bunny runtime is missing the unenv
configuration so process.env polyfills aren't injected; update the preset config
to include unenv: unenvDeno alongside exportConditions: ["deno"] so references
like process.env (used when computing _parsedPort and in the Deno.serve options)
are properly polyfilled at runtime. Locate the bunny runtime preset object that
currently sets exportConditions: ["deno"] (or similar) and add the unenv:
unenvDeno property to that same config.
In `@test/presets/bunny.test.ts`:
- Around line 16-29: The spawned Deno process from the execa(...) call is never
captured and therefore never killed; update the test to store the returned child
process (from execa(...)) into a variable (e.g., proc) and replace the no-op
ctx.server.close with a callback that terminates that process (e.g., proc.kill()
/ proc.kill("SIGKILL") or proc.cancel() per execa API) so the Deno process
running bunny-edge-scripting.mjs is reliably stopped when ctx.server.close() is
invoked; keep the same env/NITRO_PORT setup and use ctx.outDir to locate the
script as before.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Discussed privately
❓ Type of change
📚 Description
This is an experimental preset to be used on Bunny.net Edge Scripting.
The serverless platform is built ontop of Deno, with accessible pricing and ease of use, but it does come at the cost of some challanging limitations (single-file bundle artifact, 10MB max; 500ms max startup; 128MB memory; etc.), nothing that Nitro is not currently able to handle.
📝 Checklist