[pr] Borsh Serialize solana_sdk::Transaction

[DudessaPr]

Problem

In svm-rollup pr we are using Transaction inside of CallMessage, which requires Borsh

Summary of Changes

Added BroshSerialization/Deserialization to Transaction struct, and other structs inside of it, such as Signature, CompiledInstruction, etc.

Fixes #

[jason-nitro]

Just a Rust language question.. was the lifetime annotation required here? I would've thought this was a case where it was just implicit.

[DudessaPr]

It was required by trait definition of arbitrary::Arbitrary
pub trait Arbitrary<'a>: Sized {

[Yiwen-Gao]

Can you elaborate on why Arbitrary and Proptest are needed? It'd be helpful to link code snippets as well.

[Yiwen-Gao]

They're testing libraries, so even if we do need them, I believe they should be gated behind configuration flags.

[DudessaPr]

Can you elaborate on why Arbitrary and Proptest are needed? It'd be helpful to link code snippets as well.

I see some sovereign modules use Arbitrary and Proptest for fuzz testing. And in the module template we had those created derived, I mean they had the following in callMessage

#[cfg_attr(
    feature = "arbitrary",
    derive(arbitrary::Arbitrary, proptest_derive::Arbitrary)
)]

I believe we will need those crates in the future for more testing to find bugs in the module. Therefore, decided not to remove it from CallMessage and implement it for the Transaction type.

[DudessaPr]

They're testing libraries, so even if we do need them, I believe they should be gated behind configuration flags.

You are right, I missed adding flags here. I did not think about them and totally forgot. Will change that