Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

fix(engines): resolve identity blueprint vars and create variables#115

Merged
davemooreuws merged 1 commit intomainfrom
identity-blueprint-vars
Oct 13, 2025
Merged

fix(engines): resolve identity blueprint vars and create variables#115
davemooreuws merged 1 commit intomainfrom
identity-blueprint-vars

Conversation

@tjholm
Copy link
Copy Markdown
Member

@tjholm tjholm commented Oct 13, 2025

Ensure variables are properly created and resolved for identity blueprints.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 13, 2025

📝 Walkthrough

Walkthrough

The change adds tracking of identity-related Terraform modules and blueprints within TerraformDeployment via two new internal maps, initialized in NewTerraformDeployment. In resolveService, it derives an identity module name, prepares variables, creates the identity module, stores it in terraformIdentityResources, and records the corresponding blueprint in identityBlueprints. The identity module’s output remains stored under the identity type key. In TerraformEngine.Apply, it adds a step to resolve tokens for all tracked identity modules using their blueprints, erroring if a blueprint is missing or token resolution fails, and runs this before synthesizing the deployment.

Possibly related PRs

Suggested reviewers

  • davemooreuws
  • jyecusch
  • raksiv

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed The description directly refers to ensuring variable creation and resolution for identity blueprints, which aligns with the changes in the pull request and is not off-topic or unrelated.
Title Check ✅ Passed The title succinctly describes the primary change, namely fixing the engines to resolve identity blueprint variables and create the necessary variables, following conventional commit style and matching the code changes around TerraformDeployment and TerraformEngine.Apply.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from raksiv October 13, 2025 06:16
@tjholm tjholm changed the title fix(engines): resolve identity blueprint vars and create variables. fix(engines): resolve identity blueprint vars and create variables Oct 13, 2025
@davemooreuws davemooreuws merged commit a536261 into main Oct 13, 2025
3 of 4 checks passed
@davemooreuws davemooreuws deleted the identity-blueprint-vars branch October 13, 2025 21:56
@nitric-bot
Copy link
Copy Markdown

🎉 This PR is included in version 0.1.24 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants