bruteforce-crc.cc: Fix errors with initial & example implementation
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Issue nitram2342#4. 1. Since `initial` was declared to be `uint32_t`, the conversion of the argument should likewise be converted to `uint32_t`. `size_t` converts it to 8-bytes, which will not fit into 4-bytes. 2. `probe_initial` should be set to false by default to prevent the current bug. The current bug causes the program to ignore the user specified value `--initial x` and bruteforce crc seeds. Signed-off-by: Solomon Tan <solomonbstoner@yahoo.com.au>
This commit fixes nitram2342#5 (ie Issue nitram2342#5). This is a classic fencepost problem. Signed-off-by: Solomon Tan <solomonbstoner@yahoo.com.au>
solomonbstoner
changed the title
initialinitial & example implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4. Fixes #5.
Since
initialwas declared to beuint32_t, the conversion of theargument should likewise be converted to
uint32_t.size_tconvertsit to 8-bytes, which will not fit into 4-bytes.
probe_initialshould be set to false by default to prevent thecurrent bug. The current bug causes the program to ignore the user
specified value
--initial xand bruteforce crc seeds.The extra byte output is a typical fence post problem. Fixed with
this PR.
Signed-off-by: Solomon Tan solomonbstoner@yahoo.com.au