Added new code

nitinda · Nov 30, 2019 · 5cb1f22 · 5cb1f22
1 parent 29d98b0
commit 5cb1f22
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 13 deletions.
diff --git a/security-groups.tf b/security-groups.tf
@@ -4,19 +4,21 @@ resource "aws_security_group" "security_group" {
   vpc_id                 = var.vpc_id
   revoke_rules_on_delete = var.revoke_rules_on_delete 
 
-  dynamic "ingress" {
-    for_each = var.ingress_rules
-    content {
-      from_port       = ingress.value["from_port"]
-      to_port         = ingress.value["to_port"]
-      protocol        = ingress.value["protocol"]
-      cidr_blocks     = [ingress.value["cidr_blocks"]]
-      description     = ingress.value["description"]
-      self            = ingress.value["self"]
-      security_groups = [split(",",ingress.value["security_groups"])]
-    }
-  }
+  // dynamic "ingress" {
+  //   for_each = var.ingress_rules
+  //   content {
+  //     from_port       = ingress.value["from_port"]
+  //     to_port         = ingress.value["to_port"]
+  //     protocol        = ingress.value["protocol"]
+  //     cidr_blocks     = [ingress.value["cidr_blocks"]]
+  //     description     = ingress.value["description"]
+  //     self            = ingress.value["self"]
+  //     // security_groups = [split(",",ingress.value["security_groups"])]
+  //   }
+  // }
 
+  ingress = var.ingress_rules
+
   // dynamic "egress" {
   //   for_each = var.egress_rules
   //   content {

diff --git a/variables.tf b/variables.tf
@@ -21,9 +21,19 @@ variable "common_tags" {
 
 variable "ingress_rules" {
     description = "Ingress rules for security group"
-    type        = list(map(string))
+    type        = list(object({
+        from_port       = string
+        to_port         = number
+        protocol        = string
+        cidr_blocks     = list(string)
+        description     = string
+        self            = bool
+        security_groups = list(string)
+  }))
 }
 
+
+
 variable "egress_rules" {
     description = "Egress rules for security group"
     type        = list(map(string))