-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port POI patches #1434
Port POI patches #1434
Conversation
…m the DOM bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks bug 60601: hyperlinks have to be removed one by one to avoid other errors bug 60601: unlink hyperlinks from a sheet if all hyperlinks have been removed. Patch from Joachim Piketz
…d; remove unnecessary int to short casts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@antony-liu Since #1329 merge, there are some conflicts in TestXSSFSheet.cs. Can you help resolve the conflicts? I'm not so familar with the group column logic |
There are two functions |
ed93633
to
e38b5e5
Compare
…hould be re-ported.
What's the plan for TestSetColumnGroupCollapsed? I think @artem-iron has made it work. Has any bug been ported from POI 3.16? |
I think it's due to outdated code implementation of I plan to start porting after completing POI 3.16. |
@antony-liu I don't see you changed any code about TestSetColumnGroupCollapsed in the file changes. Is it caused by the incorrect merge? Can we follow Artem's implementation? At least, his changes don't break the unit test. |
The merge is wrong. You should not remove the Assert code from Artem. Can you rollback and remerge? And then re-enable TestSetColumnGroupCollapsed test. Another choice is that you recreate a branch based on master and reapply all the rest commits to the branch. And don't touch anything about ColumnGroupCollapse |
OK. I have reverted it, and enabled the test The commit 1ade0af change code of TestSetColumnGroupCollapsed. But it is not compatible with method |
LGTM |
POI patches: