Break cycles in module dependencies #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module.metaflow-metadata-service depended upon module.metaflow-datastore for database, but at the same time the latter also depended upon former for ingress rule. We break the dependency by moving ingress rule over to the former module. Also deleting a redundant ECS Task Execution role.
sanketrathi
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module.metaflow-metadata-service depended upon module.metaflow-datastore for database,
but at the same time the latter also depended upon former for ingress rule. We break
the dependency by moving ingress rule over to the former module.
Also deleting a redundant ECS Task Execution role.Decided to retain this as this also a output that is saved to all datascience team member's
machines.