-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add App Config tab and real-time run stream viewer #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add third tab 'App Config' to LoginModeSwitch for APK configuration
- Create /run/{runId} route with real-time SSE event streaming
- Implement modular run module: hooks (useRunStream, useApkPath), components (RunStreamViewer, RunOverviewCard, RunEventsPanel, RunEventCard), lib (events, time)
- Add @run/* path alias to tsconfig for clean imports
- Store APK path in localStorage and navigate to run page on Connect
- Support default test run at /run with redirect to /run/test-run-default
- Display agent events with color coding, timestamps, sequence numbers
- Include timeline and raw JSON tabs for event inspection
- Use relative API paths (no hardcoded ports)
- Update biome ignores for generated database files
Claude-Update: no
- Replace negation pattern with explicit file paths - experimentalScannerIgnores doesn't support ! negation - Explicitly ignore packages/database/index.js and packages/database/prisma/**/*.js Claude-Update: no
✅ Fixed: Biome configuration issueIssue: Negation pattern Fix: Removed the negation pattern and specified explicit paths:
Commit: 3fa34a2 Re: Package ChangesThe changes in
All auto-generated changes from running Feature Summary✅ App Config tab on login screen |
- Set defaultValues to match the active mode's shape - Reset form with correct shape when switching modes - Preserve email field when switching between password/magic-link modes - Fixes validation error for discriminated union Claude-Update: no
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
✅ Fixed: LoginForm validation issueIssue: Cursor bot identified that Root cause: Form included all fields ( Fix (commit 54b045a):
Test results: ✅ All 29 unit tests passed Current PR StatusCommits:
All changes verified:
Waiting for GitHub Actions to complete... |
✅ Verification CompleteAll changes pushed and verified:
Local validation:
GitHub Actions: Pending (workflows starting) The feature is ready - just waiting for CI to finish running the full test suite on GitHub. |
- Add packages/database/**/*.js to .gitignore (with spec.js exception) - Remove generated files that were causing lint errors - Clean up biome.json (remove unnecessary experimentalScannerIgnores) - These files are auto-generated by TypeScript and should not be committed Claude-Update: no
- Add contracts: AppPath, AppLaunchConfig, AppLaunchConfigSuccess schemas - Add routes helper: buildStreamPath, buildStartRunPath - Add POST /agents/runs/start endpoint (postLaunchRun) - Update LoginForm app-config to call new endpoint before navigation - Auto-connect to stream on RunStreamViewer mount - Add generateRunId helper for deterministic run ID generation - Add tests for run-launch schemas (8 tests, all passing) Resolves #70 - stream now auto-starts after app config submission Claude-Update: no
Summary
Checklist
Links
Copilot Review Note
Note
Adds a run viewer route with real-time SSE event streaming and introduces an App Config login mode that stores APK path and redirects to a generated run.
apps/web/app/run/page.tsx(redirect) andapps/web/app/run/[runId]/page.tsxwith metadata.@run/*module providingRunStreamViewer,RunEventsPanel,RunEventCard, and hooksuseRunStream(SSE connect/disconnect, stats, error handling) anduseApkPath.LoginFormandLoginModeSwitchwith newapp-configmode, validatingapkPath, storing it per run inlocalStorage, generatingrunId, and redirecting to/run/{runId}; refactors default mode handling and conditional fields.@run/*alias inapps/web/tsconfig.json..gitignore,.biomeignore, andbiome.jsonto ignore generated database JS/.d.ts outputs.packages/database/prisma/**andpackages/database/index.js.Written by Cursor Bugbot for commit e4240df. This will update automatically on new commits. Configure here.