Skip to content

Commit

Permalink
mm: memcg: rename charge move-related functions
Browse files Browse the repository at this point in the history
Rename exported function related to the charge move to have the memcg1_
prefix.

Link: https://lkml.kernel.org/r/20240625005906.106920-6-roman.gushchin@linux.dev
Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Muchun Song <muchun.song@linux.dev>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
rgushchin authored and akpm00 committed Jul 5, 2024
1 parent e548ad4 commit b9eaacb
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 15 deletions.
14 changes: 7 additions & 7 deletions mm/memcontrol-v1.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ static bool mem_cgroup_under_move(struct mem_cgroup *memcg)
return ret;
}

bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg)
bool memcg1_wait_acct_move(struct mem_cgroup *memcg)
{
if (mc.moving_task && current != mc.moving_task) {
if (mem_cgroup_under_move(memcg)) {
Expand Down Expand Up @@ -1056,7 +1056,7 @@ static void mem_cgroup_clear_mc(void)
mmput(mm);
}

int mem_cgroup_can_attach(struct cgroup_taskset *tset)
int memcg1_can_attach(struct cgroup_taskset *tset)
{
struct cgroup_subsys_state *css;
struct mem_cgroup *memcg = NULL; /* unneeded init to make gcc happy */
Expand Down Expand Up @@ -1126,7 +1126,7 @@ int mem_cgroup_can_attach(struct cgroup_taskset *tset)
return ret;
}

void mem_cgroup_cancel_attach(struct cgroup_taskset *tset)
void memcg1_cancel_attach(struct cgroup_taskset *tset)
{
if (mc.to)
mem_cgroup_clear_mc();
Expand Down Expand Up @@ -1285,7 +1285,7 @@ static void mem_cgroup_move_charge(void)
atomic_dec(&mc.from->moving_account);
}

void mem_cgroup_move_task(void)
void memcg1_move_task(void)
{
if (mc.to) {
mem_cgroup_move_charge();
Expand All @@ -1294,14 +1294,14 @@ void mem_cgroup_move_task(void)
}

#else /* !CONFIG_MMU */
static int mem_cgroup_can_attach(struct cgroup_taskset *tset)
int memcg1_can_attach(struct cgroup_taskset *tset)
{
return 0;
}
static void mem_cgroup_cancel_attach(struct cgroup_taskset *tset)
void memcg1_cancel_attach(struct cgroup_taskset *tset)
{
}
static void mem_cgroup_move_task(void)
void memcg1_move_task(void)
{
}
#endif
Expand Down
8 changes: 4 additions & 4 deletions mm/memcontrol-v1.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ static inline int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask,
void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n);
void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n);

bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg);
bool memcg1_wait_acct_move(struct mem_cgroup *memcg);
struct cgroup_taskset;
int mem_cgroup_can_attach(struct cgroup_taskset *tset);
void mem_cgroup_cancel_attach(struct cgroup_taskset *tset);
void mem_cgroup_move_task(void);
int memcg1_can_attach(struct cgroup_taskset *tset);
void memcg1_cancel_attach(struct cgroup_taskset *tset);
void memcg1_move_task(void);

struct cftype;
u64 mem_cgroup_move_charge_read(struct cgroup_subsys_state *css,
Expand Down
8 changes: 4 additions & 4 deletions mm/memcontrol.c
Original file line number Diff line number Diff line change
Expand Up @@ -2580,7 +2580,7 @@ int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask,
* At task move, charge accounts can be doubly counted. So, it's
* better to wait until the end of task_move if something is going on.
*/
if (mem_cgroup_wait_acct_move(mem_over_limit))
if (memcg1_wait_acct_move(mem_over_limit))
goto retry;

if (nr_retries--)
Expand Down Expand Up @@ -5995,12 +5995,12 @@ struct cgroup_subsys memory_cgrp_subsys = {
.css_free = mem_cgroup_css_free,
.css_reset = mem_cgroup_css_reset,
.css_rstat_flush = mem_cgroup_css_rstat_flush,
.can_attach = mem_cgroup_can_attach,
.can_attach = memcg1_can_attach,
#if defined(CONFIG_LRU_GEN) || defined(CONFIG_MEMCG_KMEM)
.attach = mem_cgroup_attach,
#endif
.cancel_attach = mem_cgroup_cancel_attach,
.post_attach = mem_cgroup_move_task,
.cancel_attach = memcg1_cancel_attach,
.post_attach = memcg1_move_task,
#ifdef CONFIG_MEMCG_KMEM
.fork = mem_cgroup_fork,
.exit = mem_cgroup_exit,
Expand Down

0 comments on commit b9eaacb

Please sign in to comment.