Repository navigation
Conversation
- Shared common module: packet builders and one byte-stream framer for both sides - Server: per-client cleanup on disconnect, atomic login and upload-name claims, uploads written only when complete, file names confined to Files/, 0-byte separators in directory listings - Client: the keyboard thread waits on a condition the listener clears at the end of each operation; uploads of a multiple of 512 bytes now send the closing block - 33 JUnit tests (framing, server over real sockets, races) and a 23-check end-to-end script, run in GitHub Actions - Remove the course instructions PDF, the skeleton echo/newsfeed/rci examples and third-party media from the sample files; add a README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The raw test client read its socket a byte per system call, which made the 33,000-block download test time out on the CI runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nirkem
added a commit
that referenced
this pull request
Oct 5, 2026
* Rework the TFTP server and client, fix their bugs, add tests and CI - Shared common module: packet builders and one byte-stream framer for both sides - Server: per-client cleanup on disconnect, atomic login and upload-name claims, uploads written only when complete, file names confined to Files/, 0-byte separators in directory listings - Client: the keyboard thread waits on a condition the listener clears at the end of each operation; uploads of a multiple of 512 bytes now send the closing block - 33 JUnit tests (framing, server over real sockets, races) and a 23-check end-to-end script, run in GitHub Actions - Remove the course instructions PDF, the skeleton echo/newsfeed/rci examples and third-party media from the sample files; add a README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Buffer the test client's reads and give the long transfer test more time The raw test client read its socket a byte per system call, which made the 33,000-block download test time out on the CI runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Point the README badge at the renamed repo Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
nirkem
added a commit
that referenced
this pull request
Oct 5, 2026
* Rework the TFTP server and client, fix their bugs, add tests and CI - Shared common module: packet builders and one byte-stream framer for both sides - Server: per-client cleanup on disconnect, atomic login and upload-name claims, uploads written only when complete, file names confined to Files/, 0-byte separators in directory listings - Client: the keyboard thread waits on a condition the listener clears at the end of each operation; uploads of a multiple of 512 bytes now send the closing block - 33 JUnit tests (framing, server over real sockets, races) and a 23-check end-to-end script, run in GitHub Actions - Remove the course instructions PDF, the skeleton echo/newsfeed/rci examples and third-party media from the sample files; add a README Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Buffer the test client's reads and give the long transfer test more time The raw test client read its socket a byte per system call, which made the 33,000-block download test time out on the CI runner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Point the README badge at the renamed repo Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the course submission into something presentable and correct.
Bugs fixed (each reproduced against the original code first)
wait()and was woken by every ACK, DATA or broadcast, so it could run the next command mid-upload or hang forever. It now waits on a condition.'0', soexact1024.binlisted asexact1and24.bin.RRQ ../server.logread files outsideFiles/.Structure
commonmodule shared by both sides (packets + framer); server keeps the thread-per-client design.Tests
mvn verify: 7 framer tests + 26 server tests over real sockets, including races of 20 clients.tests/e2e.sh: 23 checks against the real jars.🤖 Generated with Claude Code