-
Notifications
You must be signed in to change notification settings - Fork 60
tst: add py38 dev build #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 86.14% 86.41% +0.27%
==========================================
Files 12 12
Lines 2114 2157 +43
Branches 538 538
==========================================
+ Hits 1821 1864 +43
Misses 205 205
Partials 88 88
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good also to do a pip install --pre
to catch errors early.
Looks like you'll need to change L42: - - travis_retry python -m pip install --upgrade $INSTALL_DEPENDS
+ - PYTHONWARNINGS="" travis_retry python -m pip install --upgrade $INSTALL_DEPENDS Alternately, use a different environment variable, like - py.test -vs -n auto --cov pydra --cov-config .coveragerc --cov-report xml:cov.xml --doctest-modules pydra
+ PYTHONWARNINGS="$WARN" py.test -vs -n auto --cov pydra --cov-config .coveragerc --cov-report xml:cov.xml --doctest-modules pydra The latter might be a little safer. On the whole, I'm more interested in warnings during execution than installation. |
@effigies increasing warning strictness is making the test a little too rigid, I'm inclined to revert the warnings level to default and just leave the --pre check. |
Sure, that's fine for now. I'll open an issue about checking for warnings. Maybe pytest has a way of targeting warnings caused by our code better. |
builds off #81, adding a python 3.8 developmental build