Skip to content

FIX: Workflow raises exception if result is numpy array #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

daniel-ge
Copy link

Hi guys,

this is a first ugly workaround to resolve #270
Feel free to suggest a more generic approach, because this works only for numpy arrays and probably fail for xarray.

… arrays which results in boolean array instead boolean value
@satra
Copy link
Contributor

satra commented Sep 9, 2020

@daniel-ge - thanks for bringing this up. perhaps something around the ability to retrieve a value through indexing would work for lists and arrays (numpy or xarray or dataframes for example).

let's not depend on numpy but some fundamental object construct that could tell us this is a different kind of object.

@djarecka - it would be good to look back on why the fix did not address this situation.

@djarecka
Copy link
Collaborator

djarecka commented Sep 10, 2020

@daniel-ge - thanks you for reporting and suggesting the changes. As @satra wrote, we try to avoid extra dependencies, but I did create another fix in #340. I believe this should fix the issue you experience, but will wait for your confirmation.

@satra - looks like the test I added before was not covering it, and this place was not fixed

@satra
Copy link
Contributor

satra commented Dec 4, 2020

@djarecka - isn't this not fixed?

@djarecka
Copy link
Collaborator

djarecka commented Dec 4, 2020

yes, this should be fixed, but I will double check the test

@djarecka
Copy link
Collaborator

closing the PR, since #270 has been fixed. If you still experience problems please reopen the issue

@djarecka djarecka closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More issues with numpy arrays
3 participants