Skip to content

add type-checking to the second notebook #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

yibeichan
Copy link
Collaborator

Hi, I added the type-checking to the second notebook & updated the conda env yml file with pydra==0.23.0a0 so that type-checking can work.
Let me know if anything else needs to be added.

install latest pydra for type-checking
@yibeichan yibeichan requested a review from djarecka September 18, 2023 23:08
@yibeichan
Copy link
Collaborator Author

I know.. the run has failed because I intentionally set something wrong...

# This usage is incorrect according to static type hints:
task1b = add(a="hello", b="world")
task1b()

@effigies
Copy link
Contributor

You can mark cells as expected exception raising so they don't fail.

@yibeichan
Copy link
Collaborator Author

thank you @effigies ! adding :tags: [raises-exception] fixed the problem. now we have errors from the notebook 7_twolevel_glm_nilearn, I guess it's because we installed the latest pydra, and some of my old code is raising errors...

@yibeichan
Copy link
Collaborator Author

okay, one error from the second-level glm hasn't been fixed yet; we should expect all other notebooks to be error-free at this moment

@djarecka
Copy link
Contributor

ok, thank you, I will just merge it now, so we can work on other things and come back to this issue later

@djarecka djarecka merged commit e1c91e3 into nipype:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants