-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial joss draft #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 10 10
Lines 799 799
Branches 105 105
=======================================
Hits 789 789
Misses 6 6
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I would probably add the examples as they are pretty much explanatory.
image $M$. These two operations are confusing because, while the spatial | ||
transformation projects from $R$ to $M$, the data flows in reversed way after the | ||
interpolation of the values of $M$ at the mapped coordinates $\vec{x}'$. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a section of examples, copying from the preprint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
their docs explicitly state
software documentation such as API (Application Programming Interface) functionality should not be in the paper and instead should be outlined in the software documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an example or two cannot be considered software documentation, and they will very quickly convey what the tool does (ideally, I'm imagining two images on the left with some object signifying an input transform, they feed into the snippet and the output shows the moving image deformed via T). I can take a stab on this next week, don't worry about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged! I'll work on the figure ASAP.
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
rendered