Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Read ITK's composite transforms with only affines #174

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

oesteban
Copy link
Collaborator

Enables reading the "collapsed" output of ANTs (when no nonlinear components are inside)

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 97.50% and no project coverage change.

Comparison is base (61a4685) 96.92% compared to head (321c0ee) 96.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          13       13           
  Lines        1234     1268   +34     
  Branches      189      182    -7     
=======================================
+ Hits         1196     1229   +33     
  Misses         33       33           
- Partials        5        6    +1     
Flag Coverage Δ
travis 96.92% <97.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nitransforms/base.py 99.36% <88.88%> (-0.64%) ⬇️
nitransforms/io/itk.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member

I assume we could include a pretty small example file to thoroughly exercise this?

@oesteban
Copy link
Collaborator Author

I assume we could include a pretty small example file to thoroughly exercise this?

Yeah, we should :P -- I'll add one ASAP.

@oesteban oesteban force-pushed the enh/read-composite-itk-affine-h5 branch 2 times, most recently from 89d032a to 78b9318 Compare June 13, 2023 13:12
@oesteban oesteban marked this pull request as ready for review June 13, 2023 13:13
@oesteban oesteban force-pushed the enh/read-composite-itk-affine-h5 branch 2 times, most recently from 04e85a4 to b25045e Compare June 13, 2023 14:08
@oesteban oesteban force-pushed the enh/read-composite-itk-affine-h5 branch from b25045e to 321c0ee Compare June 13, 2023 14:16
@oesteban
Copy link
Collaborator Author

Added tests - merging in :)

@oesteban oesteban merged commit 31a2484 into master Jun 13, 2023
@oesteban oesteban deleted the enh/read-composite-itk-affine-h5 branch June 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants