Skip to content

Fix #149 replace _read_mat with scipy.io.loadmat #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix #149 replace _read_mat with scipy.io.loadmat #151

merged 1 commit into from
Feb 22, 2022

Conversation

@HippocampusGirl
Copy link
Contributor

  • Avoid DeprecationWarning by not using the MatFile4Reader/MatFile5Reader classes directly

@HippocampusGirl
Fix nipy#149 replace _read_mat with scipy.io.loadmat
dabc974 
- Avoid `DeprecationWarning` if using the `MatFile4Reader`/`MatFile5Reader` classes directly
@oesteban oesteban merged commit 26c2b2e into nipy:master Feb 22, 2022
@HippocampusGirl HippocampusGirl deleted the fix/deprecation-warning branch February 22, 2022 17:56
@oesteban
Copy link
Collaborator

@HippocampusGirl do you want to add your name as a contributor to the /.zenodo.json file?

@HippocampusGirl
Copy link
Contributor Author

Thanks @oesteban, I would be happy to add my name. Should I submit a separate pull request?

@oesteban
Copy link
Collaborator

oesteban commented Mar 1, 2022

Sure! Thank you!

@HippocampusGirl HippocampusGirl mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HippocampusGirl @oesteban