Update and Clean ants.segmentation #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 6, 2014 10:26
Added weight_image to input spec. Added bspline_order to input spec and updated arg formatting for bspline_fitting_distance to allow for bspline_order to be set. Updated n_iterations and convergence_threshold arg formatting to conform with other arg formatting for this class.
Gave ants.segmentation some PEP8 love. Also updated _run_interface call to include correct_return_codes which is declared in the overridden function
|
could you please also update the CHANGES file as well? |
|
Updated as an ENH |
| @@ -1,6 +1,11 @@ | |||
| Next release | |||
| ============ | |||
|
|
|||
| * ENH: Updated N4BiasCorrection input spec to include weight image and spline order. Made | |||
| argument formatting consistent. Cleaned ants.segmentation according to PEP8. | |||
There was a problem hiding this comment.
could you please add the link to the PR here as well?
|
Done! |
satra
added a commit
that referenced
this pull request
Nov 8, 2014
Update and Clean ants.segmentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated input spec and arg formatting for N4BiasFieldCorrection and cleaned up ants.segmentation for PEP8