ENH: Allow chained name_source #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should definitely add tests for this. |
| ns = trait_spec.name_source | ||
| while isinstance(ns, list): | ||
| if len(ns) > 1: | ||
| iflogger.warn('Only one name_source per trait is allowed') |
There was a problem hiding this comment.
well, we have a somewhat difficult decision here.
Former implementation iterated the name_source list until it found the first defined name_source.
Current implementation may accept undefined name_sources, but they must have a name_source as well.
In both implementations only one name_source is actually used, right?.
oesteban
changed the title
oesteban
changed the title
oesteban
changed the title
|
Hi @satra, I think this PR is ready to be considered. I've updated the description at the top, and the WIP flag replaced. |
Conflicts: CHANGES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An input trait with
name_sourcedefined and pointing to another trait that definesname_sourcepointing to a third trait now is sequentially resolved, adding the appropriate suffixes.