Fix: fsl.WarpUtils #906
Merged
Fix: fsl.WarpUtils #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1513,7 +1513,7 @@ class WarpUtilsInputSpec(FSLCommandInputSpec): | |||
| 'would typically be the file that was specified ' | |||
| 'with the --in argument when running fnirt.')) | |||
|
|
|||
| out_format = traits.Either('field', 'spline', argstr='--outformat=%s', | |||
| out_format = traits.Either('spline', 'field', argstr='--outformat=%s', | |||
There was a problem hiding this comment.
@oesteban - shouldn't this be an Enum?
There was a problem hiding this comment.
@satra is there any way to avoid opening a new branch and a new PR to apply such minor patches? (sorry for my ignorance about git and github). I've done that to fix it, but I feel it potentially annoying, isn't it?
There was a problem hiding this comment.
unfortunately no. and a change like this also requires make specs to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WarpUtils failed when trying to produce jacobian output (however, the corresponding doctest was passing ¿?). This trivial PR fixes it.