Skip to content

Conversation

@swederik
Copy link
Member

This is a bit of a mixed of a pull request of stuff required for EEG forward modelling. See https://cyclotronresearchcentre.github.io/forward/

I would say it needs some more cleanup and testing before its ready to merge, though.

There are new wrappers for:

Freesurfer

  • Transform2Talairach (mris_transform)
  • FloodfillSurface (mris_fill)

FSL

  • BETSurface (betsurf)
  • DecomposeTensor (fslmaths -tensor_decomp)

Dipy
EstimateConductivity: scales diffusion tensor eigenvalues to estimate conductivity tensor, saves 6 volume file as Nifti

Gmsh
Gmsh is a 3D finite element grid generator with a build-in CAD engine and post-processor. Its design goal is to provide a fast, light and user-friendly meshing tool with parametric input and advanced visualization capabilities.

GetDP
GetDP is a general finite element solver using mixed elements to discretize de Rham-type complexes in one, two and three dimensions. The main feature of GetDP is the closeness between the input data defining discrete problems (written by the user in ASCII data files) and the symbolic mathematical expressions of these problems.

@satra
Copy link
Member

satra commented Nov 22, 2013

@swederik - is this sth you would like to see get into 0.9? or should we punt this for next release?

@swederik
Copy link
Member Author

swederik commented Dec 2, 2013

Next release is fine, no rush! Sorry didn't notice the notification for your message.

@swederik
Copy link
Member Author

swederik commented Apr 1, 2014

I'd say this stuff is stable enough now. Could someone take a look and check that I'm not missing something? I ran make check-before-commit already, but it doesn't seem to want to change the autotests, even after I change the interface properties (e.g. units for an input)

@djarecka
Copy link
Collaborator

@swederik it looks like a big PR. Would you consider merging with master and finishing?

@swederik
Copy link
Member Author

Oh wow... I actually haven't looked at this in years. It was stupid of me to put so many things into such a large PR. I have no idea if anyone would find these interfaces useful, or if they would just be extra stuff to maintain in Nipype. The Freesurfer / FSL interfaces might be useful to others. I guess the Dipy conductivity thing and getdp / gmsh are a bit too specific to bother putting into master. I really don't have time to deal with this at the moment, so I would lean towards closing unless someone wants to put the effort into it.

@djarecka
Copy link
Collaborator

@swederik - thanks for your answer!

@satra - do you have any suggestions? should we include any of these interfaces? do you have anyone to ping, who can be interested in using and reviewing them?

@oesteban
Copy link
Contributor

I'll try to have a look

@oesteban oesteban modified the milestones: future, 0.15.0 Nov 30, 2017
@oesteban oesteban self-assigned this Nov 30, 2017
@effigies effigies closed this Jan 21, 2018
@effigies
Copy link
Member

@oesteban I know you self assigned, but it seems unlikely you'll have much time for this. Feel free to reopen if I'm wrong.

@effigies
Copy link
Member

This pull request is "orphaned," which means it has been deemed to be abandoned by its original author. Orphaned pull requests have not been rejected, and we hope that if a user sees one that will meet their needs with a little work, that they will fork it and open a new pull request (or, in the case of the original author, reopen the original PR).

We ask that all adopted PRs be updated to merge or rebase the current master. If you would like to adopt a PR and need help getting started, any of a number of contributors will be happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants