Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: FILMGLS gifti output support in surface mode #3652

Merged
merged 4 commits into from
Oct 6, 2024

Conversation

bogpetre
Copy link

@bogpetre bogpetre commented Jun 1, 2024

Summary

Fixes # .

FILMGLS is an interface for the FSL utility (film_gls) that fits GLM models to fMRI data. Most of FSL is only compatible with NIFTI files and NIFTI variants (e.g. NIFTI_GZ), but modern versions of film_gls in particular support gifti processing and output .func.gii files if a surface mode argument is included when invoking film_gls. Surface mode selection is supported by nipype but cannot be used in nipype workflows due to automated substitution of supported extensions for FSL outputs. With most FSL utilities the extension used to specify output files on the command line automatically selects the output format FSL uses, but film_gls in surface mode produces *.func.gii file in spite of this substitution. When workflow nodes downstream of FILMGLS then attempt to use the outputs of a FILMGLS node they're given the wrong filenames, namely files with NIFTI extensions rather than GIFTI extensions. This produces an error because such files do not exist. This enhancement addresses this issue in two ways.

  • addition of GIFTI output file type to class Info of interfaces.fsl.base
  • automatic assignment of GIFTI to output_type in FILMGLS constructor if (1) mode is set to 'surface' (2) no output_type is specified and (3) FSL version > 5.0.6

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.89%. Comparing base (83e3903) to head (1019455).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
nipype/interfaces/fsl/model.py 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3652      +/-   ##
==========================================
- Coverage   70.89%   70.89%   -0.01%     
==========================================
  Files        1277     1277              
  Lines       59212    59218       +6     
  Branches     9799     9802       +3     
==========================================
+ Hits        41980    41982       +2     
- Misses      16066    16069       +3     
- Partials     1166     1167       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

.zenodo.json Outdated Show resolved Hide resolved
@effigies effigies merged commit b93b08e into nipy:master Oct 6, 2024
19 checks passed
@effigies effigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants