Skip to content

MAINT: Set minimum yapf for checkspecs to 0.27 #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

effigies
Copy link
Member

Summary

make specs currently flails a bit from user to user, apparently because yapf has changed its formatting rules.

Additionally, we've been ignoring errors reported by make specs, probably because they weren't really clearly errors.

List of changes proposed in this PR (pull-request)

  • Set a new minimum version of yapf >=0.27. I've verified that 0.27 and 0.28 both give the same result, while 0.26 gives the old result.
  • Add extensions metadata to list of accepted metadata to reduce noise
  • Remove exists metadata from non-file traits as well as mandatory=False metadata

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the 1.2.3 milestone Sep 16, 2019
@effigies
Copy link
Member Author

Any objections?

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@effigies effigies merged commit 00ff336 into nipy:master Sep 16, 2019
@effigies effigies deleted the test/make_specs branch September 16, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants