MAINT: Set minimum yapf for checkspecs
to 0.27
#3033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make specs
currently flails a bit from user to user, apparently becauseyapf
has changed its formatting rules.Additionally, we've been ignoring errors reported by
make specs
, probably because they weren't really clearly errors.List of changes proposed in this PR (pull-request)
yapf >=0.27
. I've verified that 0.27 and 0.28 both give the same result, while 0.26 gives the old result.extensions
metadata to list of accepted metadata to reduce noiseexists
metadata from non-file traits as well asmandatory=False
metadataAcknowledgment