-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: Add mrrtrix3.MRResize
interface
#3031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mrresize
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! I have a few suggestions.
nipype/interfaces/mrtrix3/utils.py
Outdated
desc='scale the image resolution by the supplied factor. This can be ' | ||
'specified either as a single value to be used for all ' | ||
'dimensions, or as a comma-separated list of scale factors for ' | ||
'each dimension.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, something like
desc='Scale factors to rescale the image by in each dimension'
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Just as a heads up, you can test your doctests locally with:
I think you're going to need to create new interfaces for each of the three examples, or you're going to get bitten by the |
Codecov Report
@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
+ Coverage 67.5% 67.74% +0.23%
==========================================
Files 344 344
Lines 44068 44732 +664
Branches 5555 5758 +203
==========================================
+ Hits 29747 30302 +555
- Misses 13575 13651 +76
- Partials 746 779 +33
Continue to review full report at Codecov.
|
Great catch! I was also missing a coma |
mrresize
commandmrrtrix3.MRResize
interface
LGTM. Thanks! |
Summary
Adds a new interface for MRtrix's
mrresize
commandSplits #3008 into 2 PRs.
List of changes proposed in this PR (pull-request)
Acknowledgment