-
Notifications
You must be signed in to change notification settings - Fork 532
FIX: Disallow returning None
in pipeline.utils.load_resultfile
#3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3023 +/- ##
==========================================
- Coverage 67.52% 64.18% -3.35%
==========================================
Files 344 342 -2
Lines 44045 43988 -57
Branches 5552 5546 -6
==========================================
- Hits 29740 28232 -1508
- Misses 13566 14639 +1073
- Partials 739 1117 +378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3023 +/- ##
==========================================
- Coverage 67.51% 64.18% -3.34%
==========================================
Files 344 342 -2
Lines 44045 43988 -57
Branches 5550 5546 -4
==========================================
- Hits 29739 28232 -1507
- Misses 13567 14639 +1072
- Partials 739 1117 +378
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rest of the changes look like reasonable replacements. but the change in report_crash
i think requires checking what result
is.
as part of the clean_node subfunction in multiproc, result could be set to None.
I caught one more bug (rebase False not being honored). This PR should be ready to merge. Please note that I'm marking one test condition as xfail with python 2 - not sure it is worth digging up the pickling of Files with Jan 2020 this close. |
Prevents nipy#3009 and nipy#3014 from happening - although this might not solve those issues, this patch will help find their origin by making ``load_resultfile`` more strict (and letting it raise exceptions). The try .. except structure is moved to the only place is was being used within the Node code.
6a13f90
to
a200bc5
Compare
Summary
Purpose: make the handling of result files more robust.
List of changes proposed in this PR (pull-request)
Prevents #3009 and #3014 from happening - although this might not solve those issues,
this patch will help find their origin by making
load_resultfile
more strict (andletting it raise exceptions).
The try .. except structure is moved to the only place is was being used within the Node code.
Acknowledgment